Created a docker-compose file for development purpose#1644
Conversation
…cilitate server execution with no necessity of using solid-test script
TallTed
left a comment
There was a problem hiding this comment.
One additional tweak should be made to line 257 of README.md,
changing the existing —
Run with:
— to —
Once the image is built by either method, run it with —
| If you want to use Docker in development, then you can build it locally with: | ||
|
|
||
| Using docker-compose |
There was a problem hiding this comment.
| If you want to use Docker in development, then you can build it locally with: | |
| Using docker-compose | |
| If you want to use Docker in development, you can build the image | |
| locally with either docker-compose — |
| docker-compose up -d | ||
| ``` | ||
|
|
||
| or build image manually and run it: |
There was a problem hiding this comment.
| or build image manually and run it: | |
| — or these manual commands — |
| ### Development usage | ||
|
|
||
| If you want to use Docker in development, then you can build it locally with: | ||
| If you want to use Docker in development, you can build and run the image locally with either docker-compose: |
There was a problem hiding this comment.
Colon is not correct here. M-dash is.
| If you want to use Docker in development, you can build and run the image locally with either docker-compose: | |
| If you want to use Docker in development, you can build and run the image locally with either docker-compose — |
There was a problem hiding this comment.
Ok. I replaced colon by M-dash. Please, check it's ok now. Tks.
| ``` | ||
|
|
||
| or build image manually and run it: | ||
| or these manual commands: |
There was a problem hiding this comment.
M-dash leading into continued text is correct. Closing colon is also not correct; M-dash is again.
| or these manual commands: | |
| — or these manual commands — |
TallTed
left a comment
There was a problem hiding this comment.
Re-suggesting a couple of changes.
It appears to me that the docker-compose instruction does not launch the image. If that is correct, then either the image launch following the manual build should be broken back out (so it applies to both build methods), or an image launch command should be added to the docker-compose command sequence (so both build sequences end with image launch).
Hi @TallTed docker-compose comand here, in the way it was created, build the image and launch them. Once I'm doing docker-compose "up -d", it's launch the image. You could observe at the sscrip that there is a<build .> key, it's mean that docker-compose will build the image in the case it wasn't built yet |
| container_name: solid | ||
| ports: | ||
| - "8443:8443" | ||
| entrypoint: npm run solid start -- --no-reject-unauthorized |
There was a problem hiding this comment.
question Why is --no-reject-unauthorized added? And why is the same(?) thing added as an env variable below as well?
There was a problem hiding this comment.
Hi @angelo-v
Because it's exactly same thing that bin/solid-test is doing, as you can see:
// Disable rejectUnauthorized when starting the server
if [ "$COMMAND" == "start" ]; then
ADD_FLAGS="--no-reject-unauthorized"
export NODE_TLS_REJECT_UNAUTHORIZED=0
fi
Respectfully speaking and excuse my sincerity, but this is simple docker-compose to help developer (like me) to running up application easily. But it is stuck in here for a long 1 month and ithas been generating so much questions that seems unbelieve to me.. Please feel free to decline.
There was a problem hiding this comment.
Thanks for the hint @paulorodriguesxv I now understand and I think we can just merge it.
I totally understand your frustration. Unfortunately node-solid-server does not get much attention from the community anymore. Only a tiny group of volunteers keeping an eye on it more or less. I have the permission to merge and will do it, but I am not a NSS maintainer in any regard
|
The build failed at "Run bash test/surface/run-solid-test-suite.sh $BRANCH_NAME" because this does not work well with forks. Since the rest of the pipeline ran successfully and the solid-test-suite is not relevant here, I wil merge anyway |
It was created a docker-compose file for development purpose. It's facilitate server execution with no necessity of using solid-test script