Skip to content

Update index.html#1627

Merged
bourgeoa merged 10 commits into
mainfrom
jeff-zucker-patch-1
Oct 29, 2021
Merged

Update index.html#1627
bourgeoa merged 10 commits into
mainfrom
jeff-zucker-patch-1

Conversation

@jeff-zucker

Copy link
Copy Markdown
Member

No description provided.

Comment thread default-templates/server/index.html Outdated
jeff-zucker and others added 3 commits October 22, 2021 09:42
Comment thread default-templates/server/index.html Outdated
Comment thread default-templates/server/index.html
Comment thread default-templates/server/index.html Outdated
Comment thread default-templates/server/index.html
Comment thread default-templates/server/index.html Outdated
Comment thread default-templates/server/index.html Outdated
Comment thread default-views/account/register-form.hbs Outdated
Comment thread default-templates/server/index.html Outdated
Comment thread default-templates/server/index.html Outdated
Comment thread default-templates/server/index.html Outdated
Comment thread default-templates/server/index.html Outdated
jeff-zucker and others added 5 commits October 28, 2021 09:17
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Comment thread default-templates/server/index.html Outdated
Co-authored-by: Timea <timea.turdean@gmail.com>
@timea-solid

timea-solid commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

I tested it locally and it looks ok. Ready to merge

@bourgeoa

Copy link
Copy Markdown
Member

The index.html file being edited serverside at each NSS it may be wise to have the script and style in separate files. These can be located in common folder like actually.
Interestingly https://github.com/solid/node-solid-server/blob/main/common/js/auth-buttons.js contained login/logout functions not needing to call for mashlib and could be the basis example for an independant webapp.

@timea-solid timea-solid deleted the jeff-zucker-patch-1 branch December 23, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants