New ACL#147
Merged
Merged
Conversation
Contributor
Author
|
It finally passes all the tests, I am currently skipping tests for Groups (I have commented out Group implementation), for Owner-only (since we are not using it yet - at least not currently implemented) and for Glob. I also commented the clean up since I changed the files I used for testing, so it became obsolete |
Contributor
There was a problem hiding this comment.
Maybe we can replace the hardcoded value with the config/param one.
Contributor
Author
There was a problem hiding this comment.
that is opts.suffix, you can pass the suffix. (we actually pass it in here: https://github.com/nicola/ldnode/blob/solid-acl/lib/acl.js#L348)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress