Make ffi-napi work on Android under Termux#151
Open
tarmack wants to merge 2 commits into
Open
Conversation
1 similar comment
Contributor
|
@tarmack If this is something you’d like to see merged, it needs to keep working as it currently does on existing platforms, including the prebuilt binaries. |
| "ref-array-di": "^1.2.1" | ||
| }, | ||
| "scripts": { | ||
| "install": "node-gyp-build", |
There was a problem hiding this comment.
Hi @tarmack, removing prebuild script here results in broken build for appveyor over Node v12 since there is the following condition if ($env:nodejs_version -eq "12") then npm run prebuild.
Are you planning to fix this on your PR ?
Regards,
Antony
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These small changes make ffi-napi compile and work in Termux under Android.