Any progress on this? I need it for electron 5 compatibility (node v12). Thanks!

This pull request works properly at Electron 5 and Node.js v12. Please merge it!

I've build my application with electron 5 and the pull request and also works fine, maybe it should be merged in order to use this fantastic module in future electron releases? thanks in advance!

For me it worked as well! It would be nice to have it as an official release.

Is there an update on this PR?

@TooTallNate any chance to get this merged and released?

@lxe could you make some additional commit to the PR to trigger CI jobs again as for now, the PR looks like not working. Also, I see in package.json that you are using your forks as dependencies. Do you even consider this PR as a completed work?

seems that we need to wait for TooTallNate/ref#114 which depends on TooTallNate/node-weak#98

For me, it did not work with Electron 5.0.6 and Node 12.
Will be using Electron 4 and waiting for the official fix.

Just as another data point, I have got FFI working in the node:12 docker image by using the following:

FROM node:12

ENV NODE_PATH=/usr/local/lib/node_modules

RUN npm install -g lxe/node-ffi#node-12 lxe/ref#node-12 lxe/ref-struct#node-12 --unsafe-perm

This works for now until this makes it into an official release.

I got it working with electron 5 and node 12.3.1 but with electron 6 this still fails. Any chance to make it Electron 6 compatible?

works good for me. but imho the following versions should not be changed to another github repositories :

"ref": "lxe/ref#node-12",
"ref-struct": "lxe/ref-struct#node-12"
"ref-array": "lxe/ref-array#node-12"

maybe you can push those modifications related to ref / ref-struct /ref-array to corresponding repo before this one?

really appreciated ! expect this one being merged asap.

@lxe @diegozhu

I got it working with electron 5 and node 12.3.1 but with electron 6 this still fails. Any chance to make it Electron 6 compatible?

works well with Electron 6.0.12 ( builtin node 12.x)

I think since built on napi ffi-napi should be more stable across node versions: https://github.com/node-ffi-napi/node-ffi-napi

Thanks @lxe. I'm having some trouble using this in Electron 7 (Node 12.8.1)

There are a lot of build errors when using that version.

I tried a local version of the install command above: npm install lxe/node-ffi#node-12 lxe/ref#node-12 lxe/ref-struct#node-12

However, this failed in my project, with many errors in the .cc files.

I was eventually able to get it to work by:

1. Creating an empty folder somewhere else.
2. Running npm init and using all the defaults (to create a package.json).
3. Running the local install command above.
4. Copying all the contents of the node_modules folder, and pasting it into the node_modules folder of my actual project. (On one of them, this worked right away. In another, it had an issue since there were other packages that needed rebuilding; I had to npm rebuild TheOtherPackage, then re-copy the temp node_modules folder -- except for this second pass I said "skip all" for the file conflicts.)

Messy workaround, but my project is compiling again, so it's good enough for now. Hopefully @TooTallNate will have some time soon to review the pull-requests...

I got it working with electron 5 and node 12.3.1 but with electron 6 this still fails. Any chance to make it Electron 6 compatible?

do you use electron5 and node 12 is ok? how to use it ? I’m working on this repo https://github.com/TooTallNate/NodObjC.git

Hello! These packages have been the silver bullet for me for node 12 LTS:
npm install lxe/node-ffi#node-12 lxe/ref#node-12 lxe/ref-struct#node-12
Thanks for handing out those branches.

Update: I've recently switched to using ffi-napi, and it's been working well so far. (after this slight speed-bump, due to me using an old version...)

The main reason for me switching is just that the ffi-napi library is still being maintained; this one has not been updated in over a year, and has not had a meaningful update in more than 2. (it's also broken on Node 12 and up, without the fixes above in this thread -- which for me at least, do not apply properly without installation tricks, and will likely break for node 14+ anyway)

Update: I've recently switched to using ffi-napi, and it's been working well so far. (after this slight speed-bump, due to me using an old version...)

The main reason for me switching is just that the ffi-napi library is still being maintained; this one has not been updated in over a year, and has not had a meaningful update in more than 2. (it's also broken on Node 12 and up, without the fixes above in this thread -- which for me at least, do not apply properly without installation tricks, and will likely break for node 14+ anyway)

agreed. IMO node-ffi-napi is the future and should be recommended.