fix: Correct Node versions were not installed on test matrix#846
Merged
tinovyatkin merged 15 commits intonode-fetch:masterfrom Jun 10, 2020
tinovyatkin:fix-node-versions-for-actions
Merged
fix: Correct Node versions were not installed on test matrix#846tinovyatkin merged 15 commits intonode-fetch:masterfrom tinovyatkin:fix-node-versions-for-actions
tinovyatkin merged 15 commits intonode-fetch:masterfrom
tinovyatkin:fix-node-versions-for-actions
Conversation
NotMoni
reviewed
May 29, 2020
xxczaki
approved these changes
May 29, 2020
NotMoni
approved these changes
May 29, 2020
This was referenced May 31, 2020
Closed
Contributor
|
Hello, this issue is blocking the release |
Richienb
previously requested changes
Jun 9, 2020
We test both AbortControllers in test/main, nothing to swap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in GitHub Action workflow resulted in all tests were running only on Node 12.x
Also now tests on minimum node version from
package.jsonenginesinstead of any10.xThe test fornetwork-error partial responsewas failing on Node 10.16 and set conditionally.I've expected it to be fixed by #845, but it seems that there is some underlying problem in Node <12.10 (I do believe it's nodejs/node#29376). This probably may be attended in a separate PR or leave as is (the functionality difference is that on Node < 12.10
fetchis resolving with a partial response)Fixes test for a partial response that was failing on Node < 12.10 due to nodejs/node#29376 by backporting changes from that PR.