Skip to content

Remove unnecessary sqlite code#3000

Merged
stevenbird merged 1 commit intonltk:developfrom
JelleZijlstra:patch-1
May 13, 2022
Merged

Remove unnecessary sqlite code#3000
stevenbird merged 1 commit intonltk:developfrom
JelleZijlstra:patch-1

Conversation

@JelleZijlstra
Copy link
Copy Markdown
Contributor

OptimizedUnicode has been an alias for str since Python 3.2 and is scheduled for removal in Python 3.12. The default factory is already str, so the line wasn't doing anything.

See python/cpython#92547.

`OptimizedUnicode` has been an alias for `str` since Python 3.2 and is scheduled for removal in Python 3.12. The default factory is already `str`, so the line wasn't doing anything.

See python/cpython#92547.
Copy link
Copy Markdown

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Jelle.

@stevenbird stevenbird merged commit 00219c2 into nltk:develop May 13, 2022
@stevenbird
Copy link
Copy Markdown
Member

Thanks @JelleZijlstra, @erlend-aasland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants