feat(provider): detect and warn on history rewrite breaking KV cache#3
Draft
nilo85 wants to merge 1 commit into
Draft
feat(provider): detect and warn on history rewrite breaking KV cache#3nilo85 wants to merge 1 commit into
nilo85 wants to merge 1 commit into
Conversation
2748d5f to
b4ceb14
Compare
Add detection for when messages sent to the LLM differ between turns, which breaks KV cache prefix matching. Logs a warning with a formatted diff showing what changed and why. Catches issues like empty reasoning_content being added to messages that previously had none (PR anomalyco#28352), as well as any other message mutations during transformation.
b4ceb14 to
0dc861c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add detection for when messages sent to the LLM differ between turns, which breaks KV cache prefix matching. Logs a warning with a formatted diff showing what changed and why.
Catches issues like empty reasoning_content being added to messages that previously had none (PR anomalyco#28352), as well as any other message mutations during transformation.
Issue for this PR
Closes #
Type of change
What does this PR do?
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.