Repository navigation
Consume the ni.measurementlink.pinmap.v1.client package - #1222
Merged
Merged
Conversation
Contributor
dixonjoel
marked this pull request as ready for review
September 7, 2025 15:08
dixonjoel
requested review from
bkeryan,
csjall and
mshafer-NI
as code owners
September 7, 2025 15:08
Collaborator
|
Fill out the PR description template. |
csjall
approved these changes
Sep 8, 2025
bkeryan
approved these changes
Sep 8, 2025
dixonjoel
deleted the
users/jdixon/consume-ni-pinmap-v1-client-package
branch
September 9, 2025 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Use the new ni.measurementlink.pinmap.v1.client package so we can remove the duplicated client code in this repo and re-use the pinmap client in other Python apps.
Why should this Pull Request be merged?
Single-source client code for Python for accessing the pin map service.
What testing has been done?
Updated existing tests so they still pass.