Merged
Conversation
Collaborator
Author
|
@tkrebes The GitHub runner doesn't support Python 3.7 or 3.8 anymore. |
bkeryan
commented
Mar 26, 2025
46bdbc4 to
7961297
Compare
tkrebes
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
.pyitype stub files for thehightimemodule.__new__type hints to reflect the expected args and kwargs, and added an overload for the "tzinfo in parameter 8" special case..gitignore.Why should this Pull Request be merged?
Fixes #4
What testing has been done?
Ran tox:
Did some preliminary testing with projects that depend on hightime (measurement-plugin-python, nidaqmx-python) and found some typing bugs in nidaqmx-python that were hidden by hightime's lack of type hints.