Fix for client response with content-length & code 0 RST_STREAM#1508
Open
kanongil wants to merge 2 commits intonghttp2:masterfrom
Open
Fix for client response with content-length & code 0 RST_STREAM#1508kanongil wants to merge 2 commits intonghttp2:masterfrom
kanongil wants to merge 2 commits intonghttp2:masterfrom
Conversation
szmarczak
approved these changes
May 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an intense debugging session, I found that node can complete http2 client requests with partial responses. Since it uses nghttp2 to handle the transfer, it should not be possible according to the nghttp2 programmers guide, but alas it does occur!
I managed to come up with this PR to fix the issue by simply calling the validation logic on any close with
error_code == 0. Feel free to adapt this to better fit your code style.