test(files): make SearchBuilderTest independent of shared filecache state#59484
Draft
joshtrichards wants to merge 1 commit intomasterfrom
Draft
test(files): make SearchBuilderTest independent of shared filecache state#59484joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
SearchBuilderTestless flaky by removing its dependence on a fixedstorageid infilecache.Changes
numericStorageIdper test run instead of10000filecacherows insetUp()addCacheEntry()sostorage_mtimeis assigned after defaultingmtimeWhy
This DB test currently inserts/searches rows in
filecacheusing a hard-codedstorage = 10000and only cleans up intearDown(). If stale rows exist for that storage, the assertions can pick up unrelatedfileids and fail nondeterministically in CI.Using a unique storage id makes the test self-isolating, and the
storage_mtimechange fixes a small helper bug wheremtimecould be read before default initialization.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)