Closed
Conversation
Member
|
Hmm Yes.. This is a bit odd! Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the cluster module with nexe (tested with node 6 and 5).
Although... I'm not entirely sure why...
Without the extra
replacea new worker will fork, but then hangs and doesn't ever actually do anything.With this patch the worker works as expected.
I sorta stumbled across the fix because I noticed the diff (process.nextTick vs setImmediate) from nodejs/node#8821 and thought I'd see if it did anything. Apparently it did.
Absolutely no problem if you don't want to merge this (and I'd understand if you didn't because it's a bit "odd"), but thought I'd create a PR in case it helps anyone :-)
Happy to change/clean it too :-)
(The
cluster-testis just theexpress-testwith acluster.fork()...)