Pin to a known version of minecraft data#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Use stable release tag instead of moving master branch
Problem
The package was downloading
master.tar.gzfrom GitHub with a hardcoded SHA256hash. Since
masteris a moving branch, the hash becomes invalid whenever theremote repository is updated, causing hash validation failures in CI environments.
This is a fundamental design flaw: hardcoding a hash for a moving target defeats
the purpose of hash validation, which is to ensure artifact immutability.
Solution
Switch to using a specific release tag (
3.110.1) instead of themasterbranch:3.110.1is immutable and contains all supported Minecraft versions(1.20.6, 1.21.6)
Changes
base_urlto point torefs/tags/instead ofarchive/master.tar.gzto3.110.1.tar.gz375a1c0267f395d0a04c01873ca9bae70e23e6bc32b9057d2893ce0a77d86a4aTesting
Verified that data loads correctly for both supported versions (1.20.6 and
1.21.6).