Skip to content

fix(installer): install-required-packages.sh detection and tree-validation correctness fixes - #23408

Open
stelfrag wants to merge 3 commits into
netdata:masterfrom
stelfrag:fix-install-required-packages-correctness
Open

fix(installer): install-required-packages.sh detection and tree-validation correctness fixes#23408
stelfrag wants to merge 3 commits into
netdata:masterfrom
stelfrag:fix-install-required-packages-correctness

Conversation

@stelfrag

@stelfrag stelfrag commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator
Summary
  • Various package manager fixes

@github-actions github-actions Bot added the area/packaging Packaging and operating systems support label Aug 6, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packaging/installer/install-required-packages.sh Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the robustness of the dependency installer (packaging/installer/install-required-packages.sh) by fixing distro/package-manager detection edge cases and ensuring repository/tree validation runs consistently so required packages can be resolved reliably.

Changes:

  • Fix SUSE release-file detection and align Clear Linux tree naming (clearlinux) for consistent package lookup.
  • Make package-manager selection more complete (adds pkg/FreeBSD to the interactive picker and manager-availability guard; adds pkg handling in check_package_manager()).
  • Fix tree-validation behavior and correctness (run validate_package_trees even for explicit installer <name> flows; ensure OL8 CodeReady repo creation uses privileged tee; expand tree coverage for find and adjust libmnl defaults; remove unused Python pip/requests package maps).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stelfrag
stelfrag requested a review from Ferroin August 6, 2026 07:44
Comment thread packaging/installer/install-required-packages.sh Outdated
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

@stelfrag
stelfrag marked this pull request as ready for review August 6, 2026 12:30
@stelfrag
stelfrag requested a review from a team as a code owner August 6, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/packaging Packaging and operating systems support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants