This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Feat(nvidia-smi): rewrite nvidia-smi module with native C API#318
Closed
Ehekatl wants to merge 1 commit into
Closed
Feat(nvidia-smi): rewrite nvidia-smi module with native C API#318Ehekatl wants to merge 1 commit into
Ehekatl wants to merge 1 commit into
Conversation
|
Nice! This looks way better than my slow/kludgy Python garbage. |
Member
Author
|
Ya I know @ilyam8 |
Member
|
@Ehekatl you could write it as a standalone plugin
and add a link here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure if it's acceptable...
this PR enables CGO, and embedded 3rd party lib directly under pkg.
I couldn't use go mod from source because I made some changes there (to fix nil point issue, etc
Also the chart names are slightly different from python version.
Other than that everything works well, I've being use this for quite long.