provider: Fix ruby and node providers for Windows#7577
Merged
justinmk merged 3 commits intoneovim:masterfrom Nov 17, 2017
Merged
provider: Fix ruby and node providers for Windows#7577justinmk merged 3 commits intoneovim:masterfrom
justinmk merged 3 commits intoneovim:masterfrom
Conversation
neovim-ruby-host is a ruby script. neovim-node-host is a shell script. Both don't work in cmd.exe so gem and npm provide batchfile shims. This patch returns the full path of these shims because cmd.exe knows better than neovim on what to do with these files.
justinmk
reviewed
Nov 17, 2017
| endif | ||
| if !empty($NVIM_NODE_HOST_DEBUG) | ||
| call add(args, '--inspect-brk') | ||
| endif |
Member
There was a problem hiding this comment.
this is only wanted on Windows?
just want to make sure this is intentional.
Contributor
There was a problem hiding this comment.
We should try to keep this for all systems so we can have remote debugging for plugins
Contributor
Author
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Nov 18, 2017
FEATURES: b6a603f neovim#7458 node.js remote-plugin support f5d4da0 :checkhealth : validate 'runtimepath' (neovim#7526) FIXES: e6beb60 :terminal : fix crash on resize (neovim#7547) 07931ed tui: 'guicursor': use DECSCUSR for xterm-likes (neovim#7576) f185c73 neovim#7561 'os_open: UV_EINVAL on NULL filename' e8af34d win: provider: Detect(): return *.cmd path (neovim#7577) eacd788 :checkhealth : fix check for npm and yarn (neovim#7569) a43a573 health.vim: normalize slashes for script path (neovim#7525) 69e3308 cmake: install runtime/rgb.txt d0b05e3 runtime: Fix syntax error in `runtime/syntax/tex.vim` (neovim#7518) 55d8967 tutor: some fixes (neovim#7510) CHANGES: 9837a9c remove legacy alias to `v:count` (neovim#7407) c5f001a runtime: revert netrw update (neovim#7557) 67e4529 defaults: scrollback=10000 (neovim#7556) 881f9e4 process_close(): uv_unref() detached processes (neovim#7539)
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Nov 18, 2017
FEATURES: a6de144 'viewoptions': add "curdir" flag neovim#7447 b6a603f node.js remote-plugin support neovim#7458 f5d4da0 :checkhealth : validate 'runtimepath' neovim#7526 FIXES: e6beb60 :terminal : fix crash on resize neovim#7547 f19e5d6 work around gnome-terminal memory leak neovim#7573 07931ed 'guicursor': use DECSCUSR for xterm-likes neovim#7576 f185c73 'os_open: UV_EINVAL on NULL filename' neovim#7561 e8af34d win: provider: Detect(): return *.cmd path neovim#7577 eacd788 :checkhealth : fix check for npm and yarn neovim#7569 a43a573 health.vim: normalize slashes for script path neovim#7525 69e3308 cmake: install runtime/rgb.txt d0b05e3 runtime: syntax error in `runtime/syntax/tex.vim` neovim#7518 55d8967 tutor: some fixes neovim#7510 CHANGES: 9837a9c remove legacy alias to `v:count` neovim#7407 c5f001a runtime: revert netrw update neovim#7557 67e4529 defaults: scrollback=10000 neovim#7556 881f9e4 process_close(): uv_unref() detached processes neovim#7539
sameedali
added a commit
to sameedali/neovim
that referenced
this pull request
Nov 19, 2017
* 'master' of https://github.com/neovim/neovim: (148 commits) vim-patch:8.0.0283 version bump NVIM v0.2.2 tui: setrgbf/setrgbb: emit semicolons for VTE 'viewoptions': add "curdir" flag neovim#7447 win: provider: Detect(): return *.cmd path (neovim#7577) os_nodetype: rework os_open, os_stat: UV_EINVAL on NULL filename tui: 'guicursor': use DECSCUSR for xterm-likes (neovim#7576) lint neovim#7562 :checkhealth: fix check for npm and yarn (neovim#7569) doc: Fix pathshorten() example (neovim#7571) health.vim: define highlights as `default` (neovim#7560) runtime: revert netrw update (neovim#7557) defaults: scrollback=10000 (neovim#7556) doc: test/README.md: migrate wiki info (neovim#7552) vim-patch:8.0.0227 (neovim#7548) test/unit/path_spec: expect correct buffer size (neovim#7514) health.vim: normalize slashes for script path (neovim#7525) :terminal : fix crash on resize (neovim#7547) ...
Contributor
Author
|
I mixed up the batchfile extension for |
Contributor
Author
|
Looking at the batchfile, maybe it's better to be explicit (list, not string) in Windows and handle any escaping ourselves. For some reason, batchfiles with |
Contributor
Author
|
If node client should support debugging on node v6 and v7 with https://github.com/neovim/node-client#nvim_node_host_debug, then there must be some quick version check. |
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Dec 14, 2017
Resolve neovim#7577 (comment) for Unix.
justinmk
pushed a commit
to justinmk/neovim
that referenced
this pull request
Dec 17, 2017
ci: install nodejs 8 in Appveyor, Travis provider: check node version for debug support Resolve neovim#7577 (comment) for Unix. provider: test if nodejs in ci supports --inspect-brk nodejs host for neovim requires nodejs 6+ to work properly. nodejs 6.12+ or 7.6+ is required for debug support via `node --inspect-brk`. provider: run cli.js of nodejs host directly npm shims are useless because the user cannot set node to debug mode via --inspect-brk. This is problematic on Windows which use batchfiles and shell scripts to compensate for not supporting shebang. The patch uses `npm root -g` to get the absolute path of the global npm modules. If that fails, then the user did not install neovim npm package globally. Use that absolute path to find `neovim/bin/cli.js`, which is what the npm shim actually runs with node. glob() is for a simple file check in case bin/ is removed because the npm shims are ignored now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some workarounds because of
exepathreturn non-executable files in Windows and the current viml for node provider attempts to run the shell script via node.I like to test this in Appveyor but node and ruby aren't installed there in the current builds.
This should resolve my issues mentioned in #7568 but I don't have a use case for these providers and I don't know what plugins to test these providers with besides https://github.com/clojure-vim/nvim-parinfer.js