Skip to content

updated sonarAnalyzer and changelog #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fwermelinger wants to merge 2 commits into from
Closed

updated sonarAnalyzer and changelog #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c536762
updated sonarAnalyzer and changelog
fwermelinger Jan 26, 2024
47f982c
Added release instructions to Readme.md
fwermelinger Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and adheres to a project-specific [Versioning](/README.md).

## [Unreleased]

### Changed

- Updated SonarAnalyzer to version 9 because of new .Net8 language features that otherwise cause false positives
Copy link
Copy Markdown
Contributor

@neoscie neoscie Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention the added and removed rules coming with that upgrade.
You can check branch feature/v3.1 for the rules that came with the latest v8.x release


## [3.0.5] - 2023-09-28

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion Neolution.CodeAnalysis.TestsRuleset.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<developmentDependency>true</developmentDependency>
<dependencies>
<dependency id="StyleCop.Analyzers" version="1.2.0-beta.435" />
<dependency id="SonarAnalyzer.CSharp" version="8.52.0.60960" />
<dependency id="SonarAnalyzer.CSharp" version="9.17.0.82934" />
</dependencies>
</metadata>
<files>
Expand Down
2 changes: 1 addition & 1 deletion Neolution.CodeAnalysis.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<developmentDependency>true</developmentDependency>
<dependencies>
<dependency id="StyleCop.Analyzers" version="1.2.0-beta.435" />
<dependency id="SonarAnalyzer.CSharp" version="8.52.0.60960" />
<dependency id="SonarAnalyzer.CSharp" version="9.17.0.82934" />
</dependencies>
</metadata>
<files>
Expand Down
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,11 @@ Given a version number `MAJOR.MINOR.PATCH`, an incremented number for:
### What it means in practice:
- You can (and should) always update the package to the latest `PATCH` version whenever you have the chance to do it, it should never break the build.
- Updating to the latest `MINOR` version can break the build and may require minor refactorings. But you can expect to have Roslyn code fixes and/or documentation available for the changes that are needed to fix the build.
- `MAJOR` updates will break your build and may require major refactorings.
- `MAJOR` updates will break your build and may require major refactorings.


## How to create a new release
- Create a new branch for example feature/remove-some-rule
- Update the CHANGELOG.md file with your changes according to keepachangelog.com
- Go to github and create a new release. There you can define the new version number and release stage
- The github action will create a new nuget package and push it to nuget.org