Cast handling fixed - #8
Merged
Merged
Conversation
Owner
|
Thank you for the code. I truly appreciate the thought and effort. I'm going to go ahead and merge this, however, there are two things that need to happen afterwards:
I'll work on the changes after the merge. Again, many thanks. |
Contributor
Author
|
Thank you for the merge. About the test, I couldn't figure out how tests work (how they assert the result, how to run them). I think that an additional doc about this would be very welcome. Some other issue that came out from testing this is with regard to java wrapper types (but I'll open a new ticket for this) |
Owner
|
Added docs for tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix Issue #6
A new config option is added,
objCastModewhich can take valuesdroporctor