Conversation
Lock () is no longer needed to use optimistic locking with the operating_until parameter. However, the first stage of acquiring an optimistic lock needs to be pessimistic. Therefore, the version of each key can be acquired, and Apply() and Delete() refers to it to realize a pessimistic lock.
kyontan
reviewed
Sep 24, 2019
|
|
||
| func (a *ProjectAPI) AddProjectMembership(ctx context.Context, req *piam.AddProjectMembershipRequest) (*piam.Project, error) { | ||
| if req.Membership == piam.ProjectMembership_PROJECT_MEMBERSHIP_UNSPECIFIED { | ||
| return nil, stdapi.ValidationError("member_ship", "necessary to specify any membership") |
…h provider are cycling depending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / 変更点
Why / 変更した理由
How (Optional) / 概要
How affect / 影響範囲