Ignore non-amateur frequency from Repeaterbook (instead of failing)#87
Merged
Conversation
masenf
approved these changes
May 10, 2022
masenf
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable from here. Thanks for the patch.
Contributor
Author
|
Thanks for approving it. I'm seeing a "2 workflows awaiting approval" message. I assume you'll merge this when you're ready and then the workflows will run? |
Collaborator
|
@jancona thanks for your contribution. I approved earlier today, but I didn't have a chance to run the workflows locally and merge/release until just now. Your fix is released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidently Repeaterbook can return repeaters with non-amateur frequencies, which was causing dzcb to fail. This PR instead skips that repeater and logs a warning.