[button] Document type attribute on ButtonBase#48146
Merged
mj12albert merged 3 commits intomui:masterfrom Apr 13, 2026
Merged
Conversation
Netlify deploy previewhttps://deploy-preview-48146--material-ui.netlify.app/ Bundle size report
|
3c06809 to
40b91d5
Compare
evinracher
approved these changes
Apr 1, 2026
silviuaavram
approved these changes
Apr 1, 2026
| /** | ||
| * @ignore | ||
| */ | ||
| type: PropTypes.oneOfType([PropTypes.oneOf(['button', 'reset', 'submit']), PropTypes.string]), |
Member
There was a problem hiding this comment.
is this considered a breaking change? probably not since we are expanding the allowed values.
Member
Author
There was a problem hiding this comment.
Yeah widening the type is ok ~
| */ | ||
| touchRippleRef?: React.Ref<TouchRippleActions> | undefined; | ||
| /** | ||
| * The [type](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/button#type) attribute applied to the `button` element. |
Member
There was a problem hiding this comment.
we expect the ButtonBase to also be a non-native button, maybe we need to change the documentation to reflect that.
Member
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Same comments as Silviu.
b74e7a1 to
70c2624
Compare
type attributetype attribute
Member
|
Nice, there is no such thing as a "too old regression" to fix 👍 OK: https://v3.mui.com/api/button-base/#props |
type attributetype attribute on ButtonBae
type attribute on ButtonBaetype attribute on ButtonBase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21924
Follow up to #47989
stringseems the best considering we need to account for:material-ui/packages/mui-material/src/ButtonBase/ButtonBase.test.js
Line 1512 in 51dd21f
Preview: https://deploy-preview-48146--material-ui.netlify.app/material-ui/api/button-base/#button-base-prop-type