Repository navigation
[code-infra] Remove redundant prebuild cleanup - #5977
Open
bernardobelchior wants to merge 1 commit into
Open
bernardobelchior wants to merge 1 commit into
bernardobelchior wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2 tasks done
commit: |
bernardobelchior
marked this pull request as ready for review
October 12, 2026 12:52
bernardobelchior
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz,
michaldudak and
romgrk
as code owners
October 12, 2026 12:52
Bundle size
PerformanceTotal duration: 472.46 ms -1.66 ms(-0.3%) | Renders: 76 (+0) | Paint: 860.68 ms -12.73 ms(-1.5%)
14 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the cleanup in the
prebuildscripts of@base-ui/utilsand@base-ui/react.Changes
@base-ui/utils: removedprebuild. Nothing it deleted needs deleting:build/:code-infra buildalready deletes it before building (cmdBuild.mjs#L276;buildDirispublishConfig.directory). The line is still there in the version we use (0.1.1-canary.6).*.tsbuildinfo: the build doesn't write any. code-infra emits declarations with--composite false --incremental false, into a temp dir. The only ones in the package folder come fromtsc -b(pnpm typescript). The build never reads them, and.npmignorealready excludes them.build-tests/: only the output oftsconfig.test.jsontype-checking. The build never reads it, so a stale one is harmless.@base-ui/react:prebuildis now justnode ./scripts/stagePublishedDocs.mjs. The same reasoning applies tobuild/,build-tests/,build-typecheck/(output oftsconfig.typecheck.json) and*.tsbuildinfo.published-docs/is the exception:stagePublishedDocs.mjsnow deletes it before theBASE_UI_PUBLISH_DOCSearly exit. Otherwise a stalepublished-docs/would be copied into the package through--copy "published-docs/**:docs"when the env var is unset.Verification (Node 24.19.0)
utilsandreact: ranpnpm buildon master and savedfind build -type f | sort | xargs shasum. Then, on this branch, added a stalebuild/stale.js,build-tests/,build-typecheck/(react) andstale.tsbuildinfo, and built again. The build passes,build/stale.jsis gone and the checksums match master.build/holdstsc -boutput before the build.pnpm typescriptstill passes after a build wipesbuild/and leavestsconfig.build.tsbuildinfobehind.published-docs/foo.mdandBASE_UI_PUBLISH_DOCSunset,published-docs/is removed andbuild/docs/doesn't exist.pnpm docs:generate-llms, built withBASE_UI_PUBLISH_DOCS=1and a stalepublished-docs/foo.md. 80 files were staged,build/docs/matchesdocs/public/**/*.mdbyte for byte, andfoo.mdis not included.🤖 Generated with Claude Code