[combobox][select] Fix browser autofill with object values when autofill uses the label#4560
Merged
atomiks merged 4 commits intomui:masterfrom Apr 9, 2026
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1960e81 to
0f59f83
Compare
atomiks
approved these changes
Apr 9, 2026
Contributor
atomiks
left a comment
There was a problem hiding this comment.
Thanks for the fix @mattrothenberg
Bundle size report
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using a Combobox with object values (e.g.,
{ country: 'United States', code: 'US' }), browser autofill was not working because browsers send the displayed text (label) rather than the underlying value.For example, when Chrome autofills a country field, it sends
"United States"(the label displayed to the user), not"US"(the value). The existing autofill handler only matched againstitemToStringValue, causing it to fail for object values where the label differs from the value.Changes
AriaCombobox.tsxto first try matching by value, then fall back to matching by label"Canada") instead of the value (e.g.,"CA")Test Plan
The new test (
should handle browser autofill with object values when autofill uses the label) was verified to:All existing tests continue to pass (6050 tests).