Fix minItems for all-optional array-like Structs - #1124
Open
gaoflow wants to merge 1 commit into
Open
Conversation
Merging this PR will improve performance by 10.99%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For an
array_like=TrueStruct where every user field has a default,msgspec.json.schemareportsminItemsone too high. An untagged Struct getsminItems: 1even thoughmsgspec.json.decodeaccepts[]and fills all defaults; a tagged Struct similarly gets 2 even though a tag-only array is valid. Generated schemas therefore reject payloads accepted by msgspec itself.The trailing-default loop stored the zero-based
enumerateindex and later used it as a count. When the loop never encountered a required field, that count was one short.Fix
Count trailing optional fields explicitly before calculating
minItems. The existing required-field and empty-Struct boundaries remain unchanged.The regression test covers both tagged and untagged Structs and includes a
default_factory, while checking the generated schema against the public decoder contract.Testing
just test tests/unit/test_schema.py— 124 passed, 2 skippedjust test— 6412 passed, 113 skippedjust check— lint, format, and spelling checks passed