Skip to content

test_unpack.py: add tests for ExtraData #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 1 commit into from
Jun 24, 2026
+26 −1
Merged

test_unpack.py: add tests for ExtraData #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion test/test_unpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,15 @@

from pytest import mark, raises

from msgpack import ExtType, OutOfData, Unpacker, packb
from msgpack import (
ExtraData,
ExtType,
OutOfData,
Unpacker,
packb,
unpack,
unpackb,
)


def test_unpack_array_header_from_file():
Expand Down Expand Up @@ -142,3 +150,20 @@ def ext_hook(code, data):
up.feed(b"\xdc" + struct.pack(">H", 11) + b"\xd4\x05A" + b"\x2a" * 10)
with raises(RuntimeError):
up.unpack()


def test_unpackb_raises_extra_data_with_trailing_bytes():
packed = packb(42) + packb("trailing")
with raises(ExtraData) as exc_info:
unpackb(packed)
err = exc_info.value
assert err.unpacked == 42
assert err.extra == packb("trailing")


def test_unpack_raises_extra_data_on_stream_with_trailing_bytes():
stream = BytesIO(packb(100) + packb(200))
with raises(ExtraData) as exc_info:
unpack(stream)
assert exc_info.value.unpacked == 100
assert exc_info.value.extra == packb(200)
Loading