Skip to content

Fix Unpacker max_buffer_length handling #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 7 commits into from
May 24, 2022
Merged

Fix Unpacker max_buffer_length handling #506

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ae4dac4
fix Unpacker
methane May 24, 2022
f233d0b
Unpacker raises BufferFull when max_buffer_size is not enough.
methane May 24, 2022
1531b79
black
methane May 24, 2022
1436dfb
fix test
methane May 24, 2022
8ef34c3
black
methane May 24, 2022
b1f06c3
fix test
methane May 24, 2022
9f1aceb
fallback raise BufferFull
methane May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@methane
methane committed May 24, 2022
commit b1f06c33b9cdf0aa314c058a3a807f19f3d7b401
2 changes: 1 addition & 1 deletion test/test_sequnpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_maxbuffersize():

def test_maxbuffersize_file():
buff = io.BytesIO(packb(b"a" * 10) + packb([b"a" * 20] * 2))
unpacker = Unpacker(buff, read_size=1, max_buffer_size=19)
unpacker = Unpacker(buff, read_size=1, max_buffer_size=19, max_bin_len=20)
assert unpacker.unpack() == b"a" * 10
# assert unpacker.unpack() == [b"a" * 20]*2
with raises(BufferFull):
Expand Down