Skip to content

Ressurect unicode_errors of the Packer. #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 12 commits into from
Dec 3, 2019
+50 −13
Merged

Ressurect unicode_errors of the Packer. #379

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fd83111
Revert "Remove encoding/unicode_errors options from Packer (#378)"
methane Dec 3, 2019
97da876
Remove encoding option from the Packer
methane Dec 3, 2019
d254534
fixup
methane Dec 3, 2019
2b4ffcf
fix tests
methane Dec 3, 2019
2a4a98a
Update ChangeLog.
methane Dec 3, 2019
3b582a8
fix test
methane Dec 3, 2019
a9a769d
Use surrogateescape-d input
methane Dec 3, 2019
28d737b
fix fallback
methane Dec 3, 2019
b582067
fix fallback
methane Dec 3, 2019
1963adf
Fix PY2 test
methane Dec 3, 2019
72272db
fixup
methane Dec 3, 2019
ffcff9a
fix PY2 again
methane Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PY2 test
  • Loading branch information
@methane
methane committed Dec 3, 2019
commit 1963adf9f19eb3887d80ea3a107bce4ef79d04c0
2 changes: 2 additions & 0 deletions test/test_pack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from collections import OrderedDict
from io import BytesIO
import struct
import sys

import pytest
from pytest import raises, xfail
Expand Down Expand Up @@ -54,6 +55,7 @@ def testPackByteArrays():
for td in test_data:
check(td)

@pytest.mark.skipif(sys.version_info < (3,0), "Python 2 passes invalid surrogates")
def testIgnoreUnicodeErrors():
re = unpackb(packb(b'abc\xeddef', use_bin_type=False),
raw=False, unicode_errors='ignore')
Expand Down