Skip to content

Add support for jackson field ids #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komamitsu merged 10 commits into from
Feb 11, 2025
Merged

Add support for jackson field ids #868

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
534fa03
Add test demonstrating field id case
brenbar Jan 18, 2025
481c223
Fix java 8 error
brenbar Jan 19, 2025
d8a3716
Add missing import
brenbar Jan 19, 2025
757b6f9
Add missing throws
brenbar Jan 19, 2025
546d48b
Cleanup unused imports
brenbar Jan 20, 2025
3c08b90
Cleanup test
brenbar Jan 20, 2025
84cbc79
Implement jackson field ids
brenbar Jan 20, 2025
8247f24
Address feedback from @komamitsu
brenbar Feb 3, 2025
a66fc2e
Address feedback from @komamitsu
brenbar Feb 9, 2025
9d0c9a8
Address feedback from @komamitsu
brenbar Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address feedback from @komamitsu
  • Loading branch information
@brenbar
brenbar committed Feb 9, 2025
commit a66fc2ec5f54ccdea0cb7e6914ce7655a6c282ff
23 changes: 4 additions & 19 deletions msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,33 +186,18 @@ else if (value instanceof NodeArray) {

// This is an internal constructor for nested serialization.
private MessagePackGenerator(
int features,
ObjectCodec codec,
OutputStream out,
MessagePack.PackerConfig packerConfig)
{
super(features, codec);
this.output = out;
this.messagePacker = packerConfig.newPacker(out);
this.packerConfig = packerConfig;
this.nodes = new ArrayList<>();
this.writeIntegerKeysAsStringKeys = true;
}

public MessagePackGenerator(
int features,
ObjectCodec codec,
OutputStream out,
MessagePack.PackerConfig packerConfig,
boolean reuseResourceInGenerator)
throws IOException
boolean writeIntegerKeysAsStringKeys)
{
super(features, codec);
this.output = out;
this.messagePacker = packerConfig.newPacker(getMessageBufferOutputForOutputStream(out, reuseResourceInGenerator));
this.messagePacker = packerConfig.newPacker(out);
this.packerConfig = packerConfig;
this.nodes = new ArrayList<>();
this.writeIntegerKeysAsStringKeys = true;
this.writeIntegerKeysAsStringKeys = writeIntegerKeysAsStringKeys;
}

public MessagePackGenerator(
Expand Down Expand Up @@ -393,7 +378,7 @@ else if (v instanceof MessagePackExtensionType) {
else {
messagePacker.flush();
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
MessagePackGenerator messagePackGenerator = new MessagePackGenerator(getFeatureMask(), getCodec(), outputStream, packerConfig);
MessagePackGenerator messagePackGenerator = new MessagePackGenerator(getFeatureMask(), getCodec(), outputStream, packerConfig, writeIntegerKeysAsStringKeys);
getCodec().writeValue(messagePackGenerator, v);
output.write(outputStream.toByteArray());
}
Expand Down