Skip to content

Support JDK17 #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 4 commits into from
Jun 28, 2022
Merged

Support JDK17 #660

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65188ed
Reproduce #600 (JDk17 error)
xerial Jun 28, 2022
3dc7e9d
Add workaround for Java17
xerial Jun 28, 2022
fdb537a
Add a helpful error message
xerial Jun 28, 2022
ecb4951
Add note on JDK17
xerial Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Reproduce #600 (JDk17 error)
  • Loading branch information
@xerial
xerial committed Jun 28, 2022
commit 65188edfcb7a87f17dc1fdd5b5017ec555f4d3c5
28 changes: 24 additions & 4 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,33 @@ jobs:
- uses: actions/checkout@v2
- name: jcheckstyle
run: ./sbt jcheckStyle
test_jdk17:
name: Test JDK17
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '17'
- uses: actions/cache@v2
with:
path: ~/.cache
key: ${{ runner.os }}-jdk11-${{ hashFiles('**/*.sbt') }}
restore-keys: ${{ runner.os }}-jdk17-
- name: Test
run: ./sbt test
- name: Universal Buffer Test
run: ./sbt test -J-Dmsgpack.universal-buffer=true
test_jdk11:
name: Test JDK11
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v10
- uses: actions/setup-java@v3
with:
java-version: adopt@1.11
distribution: 'zulu'
java-version: '11'
- uses: actions/cache@v2
with:
path: ~/.cache
Expand All @@ -48,9 +67,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v10
- uses: actions/setup-java@v3
with:
java-version: adopt@1.8
distribution: 'zulu'
java-version: '8'
- uses: actions/cache@v2
with:
path: ~/.cache
Expand Down
29 changes: 29 additions & 0 deletions msgpack-core/src/test/scala/org/msgpack/core/buffer/DirectBufferAccessTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
//
// MessagePack for Java
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package org.msgpack.core.buffer

import wvlet.airspec.AirSpec

import java.nio.ByteBuffer

class DirectBufferAccessTest extends AirSpec {

test("instantiate DirectBufferAccess") {
val arr = Array[Byte](0)
val bb = ByteBuffer.wrap(arr)
val addr = DirectBufferAccess.getAddress(bb)
}
}