Skip to content

Timestamp support #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 21 commits into from
May 17, 2021
Merged

Timestamp support #565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9b47f2a
Add add support for Timestamp type
frsyuki Aug 10, 2017
8a9d84e
Add timestamp tests
xerial May 11, 2021
ad6fb2d
Remove unpackTimestampMillis
xerial May 11, 2021
1bb5af7
Code cleanup
xerial May 11, 2021
b4c1448
Fix timestamp pack overflow
xerial May 11, 2021
5c97c46
Add timestamp value support
xerial May 12, 2021
4beb154
Support timestamp in unpackValue
xerial May 12, 2021
a566e76
Add type cast
xerial May 12, 2021
d8bb62d
Use AirSpec for integration with ScalaCheck
xerial May 12, 2021
28c7843
Fix ValueFactoryTest
xerial May 12, 2021
c20c76d
Use AirSpec for property tests
xerial May 12, 2021
1e4c7a3
Migrate to AirSpec
xerial May 12, 2021
2be647b
Migrate to AirSpec
xerial May 12, 2021
111fe8e
Fix test
xerial May 12, 2021
7d67105
Use plain AirSpec
xerial May 12, 2021
6c0f303
Remove scalatest
xerial May 12, 2021
81a71cd
Remove xerial-core dependency
xerial May 12, 2021
5e83c4a
Remove unnecessary dependencies
xerial May 12, 2021
f7d1d5a
Variable.writeTo roundtrip tests
xerial May 12, 2021
4030459
Use consistent code style
xerial May 12, 2021
02e6b86
Fix comments
xerial May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support timestamp in unpackValue
  • Loading branch information
@xerial
xerial committed May 12, 2021
commit 4beb154a8675c467fc5f4ab20ffbc1020af55271
8 changes: 6 additions & 2 deletions msgpack-core/src/main/java/org/msgpack/core/MessageUnpacker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,8 +720,12 @@ public Variable unpackValue(Variable var)
}
case EXTENSION: {
ExtensionTypeHeader extHeader = unpackExtensionTypeHeader();
// TODO Set TimestampValue
var.setExtensionValue(extHeader.getType(), readPayload(extHeader.getLength()));
if (extHeader.getType() == EXT_TIMESTAMP) {
var.setTimestampValue(unpackTimestamp(extHeader));
}
else {
var.setExtensionValue(extHeader.getType(), readPayload(extHeader.getLength()));
}
return var;
}
default:
Expand Down
1 change: 0 additions & 1 deletion msgpack-core/src/test/scala/org/msgpack/value/ValueFactoryTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ class ValueFactoryTest extends MessagePackSpec {
forAll { (v: Array[Byte]) =>
isValid(ValueFactory.newExtension(0, v), expected = ValueType.EXTENSION, isExtension = true, isRaw = false)
}

forAll { (millis: Long) =>
isValid(ValueFactory.newTimestamp(millis), expected = ValueType.EXTENSION, isExtension = true, isTimestamp = true)
}
Expand Down