Skip to content

msgpack-value v07 API #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xerial wants to merge 10 commits into from
Closed

msgpack-value v07 API #109

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9dae25e
#109: Applied fixes suggested by @komamitsu
xerial Jun 23, 2014
a6619fb
#109: Add a case for BINARY type in toByteBuffer
xerial Jun 30, 2014
698a92c
#109: Add comment to MessageOverflowException
xerial Jun 30, 2014
64d397c
#109: Simply convert to uint32 (long) value using a bit mask
xerial Jun 30, 2014
a2881a5
Merge branch 'v07-develop' into v07-value
xerial Nov 28, 2014
d655c03
0.7.0-M6-SNAPSHOT vesrion
xerial Nov 28, 2014
7a94130
Remove ValueRef interface
xerial Nov 28, 2014
84ac459
isImmutable is false for Array/MapCursor
xerial Nov 28, 2014
52342fe
Make Map/ArrayCursorImpl implement Value interface
xerial Nov 28, 2014
ad0bbbe
Adjust benchmark
xerial Nov 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#109: Add a case for BINARY type in toByteBuffer
  • Loading branch information
@xerial
xerial committed Jun 30, 2014
commit a6619fbec008e83032f9d48e4a76bc2b7142bf89
1 change: 1 addition & 0 deletions msgpack-core/src/main/java/org/msgpack/value/holder/RawHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public byte[] toByteArray() {
public ByteBuffer toByteBuffer() {
switch(tpe) {
case STRING:
Copy link
Copy Markdown
Member

@komamitsu komamitsu Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about BINARY?

Copy link
Copy Markdown
Member Author

@xerial xerial Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing. I will add a statement for BINARY.

case BINARY:
return buf.toByteBuffer();
default:
throw UNREACHABLE;
Expand Down