Refere ISEQ BLOCK of binary bytecode to ROM directly(rebased).#880
Refere ISEQ BLOCK of binary bytecode to ROM directly(rebased).#880kyab wants to merge 9 commits into
Conversation
|
Thank you for your re-post, @kyab. I'm interested in your hack. And there needs some additional hacks, I think. |
|
Yes, I will review your additional patch. |
Remove trailing spaces.
Avoid freeing ROM area in the error situation.
|
Thanks for your review and merge, @kyab. |
|
I just noticed our patch crashes in some phase on loading *.mrb. Maybe more hack required.. |
|
It seems a free twice bug that can find out easily, right? |
Use MRB_ENDIAN_BIG instead of is_little_endian().
|
I did a double check with foo.rb. I could run without crashes. |
|
@monaka It's strange, it should crash or at least fail to load foo.mrb. I've fixed, but might be ugly hack.. Could you please retry to reproduce crash(or fail) and review my fix? |
|
I reproduced the crash. And I checked it is stopped by the patch 67f6859. |
|
I put my comment on #964 |
|
I think this issue can be closed. |
I've implemented idea of referring ISEQ BLOCK of binary bytecode to ROM directly. Based on (6) of http://www.csk.com/fukuoka/services/mruby/nxt02.html.
I'm not sure this kind of hack is wellcome, but in my environment, around 8kb of heap can be saved by this change.