Avoid abort() when FiberError occurs in mrb_fiber_resume()#5857
Merged
Conversation
matz
reviewed
Nov 20, 2022
| } | ||
|
|
||
| static mrb_value | ||
| fiber_error_static(mrb_state *mrb, const char *mesg) |
Member
There was a problem hiding this comment.
I, as an insider, can imagine this _static means "calls mrb_str_new_static() inside", but I think it's too much to expect for others. Probably we should remove _static and add a comment that "mesg should be a literal string" or something similar.
Contributor
Author
There was a problem hiding this comment.
🐈⬛ Surely, three months from now I will be doing something.
I will fix it.
However, this may not be the case depending on where the `FiberError` raises.
fcc252f to
f0a65ec
Compare
abort() when exception occurs in mrb_fiber_resume()abort() when FiberError occurs in mrb_fiber_resume()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
However, this may not be the case depending on where the
FiberErrorraises.