Replace tempirep with RProc#5275
Merged
Merged
Conversation
Previously I used the `RData` object to avoid a memory leak in `mrb_irep` if `src/load.c` failed. ref: mruby#4250 commit: f1523d2 Considering that the `RProc` object will be created in the subsequent process, it is preferable to create the `RProc` object from the beginning. Along with this, the inside of `read_irep()` is replaced with the processing centered on the `RProc` object. The global function that returns the `mrb_irep` pointer is still provided for compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously I used the
RDataobject to avoid a memory leak inmrb_irepifsrc/load.cfailed.ref: #4250
commit: f1523d2
Considering that the
RProcobject will be created in the subsequent process, it is preferable to create theRProcobject from the beginning.Along with this, the inside of
read_irep()is replaced with the processing centered on theRProcobject.The global function that returns the
mrb_ireppointer is still provided for compatibility.