Reimplement String#upto#3701
Merged
Merged
Conversation
Member
|
Thank you. But under the current implementation, we want to avoid using |
Contributor
Author
|
@matz Should I write in Ruby? class String
def upto(other_str, excl=false, &block)
return to_enum :upto, other_str, excl unless block
unless other_str = String.try_convert(other_str)
raise TypeError, "no implicit conversion of #{other_str.class} into String"
end
# single character
if bytesize == 1 && other_str.bytesize == 1
c = bytes[0]
e = other_str.bytes[0]
return self if c > e || excl && c == e
while 1
block.call(c.chr)
break if !excl && c == e
c += 1
break if excl && c == e
end
return self
end
# both edges are all digits
if self != "0" && other_str != "0" && (b = self.to_i) > 0 && (e = other_str.to_i) > 0
min_width = length
max_width = other_str.length
while b <= e
break if excl && b == e
bs = b.to_s
bs = "#{"0" * (min_width - bs.length)}#{bs}" if min_width > bs.length
block.call(bs)
b += 1
end
return self
end
# normal case
n = self <=> other_str
return self if n > 0 || (excl && n == 0)
after_end = other_str.succ
current = dup
while current != after_end
nxt = nil
nxt = current.succ if excl || current != other_str
block.call(current)
break if nxt.nil?
current = nxt
break if excl && current == other_str
break if current.length > other_str.length || current.empty?
end
self
end
endt.rb t = Time.now
"000001".upto("100000").each {}
p Time.now - t
t = Time.now
"aaa".upto("zzz").each {}
p Time.now - tC implementation Ruby implementation |
Member
|
I am trying to solve the issue, but at the moment, I don't recommend to use |
Member
|
I am talking about #3359 |
matz
added a commit
that referenced
this pull request
Jun 16, 2017
matz
added a commit
that referenced
this pull request
Jun 16, 2017
Otherwise the function may terminate and cause memory leaks.
matz
added a commit
that referenced
this pull request
Jun 16, 2017
Contributor
Author
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented code didn't working as expected.
I've fixed like this.
The ruby/spec for
String#uptopassed all withoutEnumerator#size(using by mruby-spec)https://github.com/ruby/spec/blob/97fe8c7cfd7a7e4833ae2edab4df21e3ea6bc093/core/string/upto_spec.rb
before
after