Skip to content

use lambda's over ptr_fun#127

Merged
mrtazz merged 3 commits into
mrtazz:masterfrom
Mythra:ptr_fun
Aug 6, 2019
Merged

use lambda's over ptr_fun#127
mrtazz merged 3 commits into
mrtazz:masterfrom
Mythra:ptr_fun

Conversation

@Mythra

@Mythra Mythra commented Jul 7, 2019

Copy link
Copy Markdown

ptr_fun was deprecated in C++11, and removed in C++17. lambdas
have also been around since C++11. so there should be no loss in
supported targets, but also adds in support for C++17 and beyond.

Comment thread CMakeLists.txt
source/restclient.cc
source/connection.cc
add_library(restclient-cpp SHARED
source/restclient.cc

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my editor just automatically made these spacing changes, I am happy to change them back if you'd like.

@Mythra

Mythra commented Jul 7, 2019

Copy link
Copy Markdown
Author

Looks like this older version of gcc available in travis needs: -std=c++11 added. Would you prefer I set it to: -std=c++11, -std=c++14, or -std=c++17, or figure out how to run all three of them?

@mrtazz

mrtazz commented Jul 14, 2019

Copy link
Copy Markdown
Owner

I think I'd prefer to start with -std=c++11 for now. I don't have a good idea yet of how supported the later versions are, so I'd rather start with a more conservative requirement.

Cynthia Coan added 2 commits July 14, 2019 09:09
ptr_fun was deprecated in C++11, and removed in C++17. lambdas
have also been around since C++11. so there should be no loss in
supported targets, but also adds in support for C++17 and beyond.
@Milerius

Milerius commented Jul 28, 2019

Copy link
Copy Markdown

can we merge that, because in c++ 17 we cannot compile anymore

@Mythra

Mythra commented Aug 5, 2019

Copy link
Copy Markdown
Author

@mrtazz Any updates here? Anything I can do to help?

@mrtazz mrtazz merged commit b9055ce into mrtazz:master Aug 6, 2019
@mrtazz

mrtazz commented Aug 6, 2019

Copy link
Copy Markdown
Owner

@securityinsanity sorry for the slow response and thanks for your patience and contribution! :)

@Mythra

Mythra commented Aug 6, 2019

Copy link
Copy Markdown
Author

No worries at all! Thanks!

@Mythra Mythra deleted the ptr_fun branch August 6, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants