Docs fix object clone method documentation#9030
Merged
mrdoob merged 3 commits intomrdoob:devfrom May 31, 2016
aardgoose:docs-fix-object-clone
Merged
Docs fix object clone method documentation#9030mrdoob merged 3 commits intomrdoob:devfrom aardgoose:docs-fix-object-clone
mrdoob merged 3 commits intomrdoob:devfrom
aardgoose:docs-fix-object-clone
Conversation
Collaborator
|
Many thanks for this. I wonder if instead of using the term descendants, the term children would be better -- just for consistency. descendants is only used in a couple of other doc files, and those instances could be changed, too. |
Contributor
|
Isn't children and descendants two different things though? In my mind children is only the direct children (one level deep) while descendants are n levels deep - children, grandchildren etc. Not a native english speaker though, so might be mistaken. |
Collaborator
|
@GGAlanSmithee Good point. |
Contributor
Author
|
That was my reasoning, Descendants is more accurate and Object3D already uses that term. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.