Skip to content

Docs fix object clone method documentation#9030

Merged
mrdoob merged 3 commits intomrdoob:devfrom
aardgoose:docs-fix-object-clone
May 31, 2016
Merged

Docs fix object clone method documentation#9030
mrdoob merged 3 commits intomrdoob:devfrom
aardgoose:docs-fix-object-clone

Conversation

@aardgoose
Copy link
Copy Markdown
Contributor

No description provided.

@WestLangley
Copy link
Copy Markdown
Collaborator

Many thanks for this.

I wonder if instead of using the term descendants, the term children would be better -- just for consistency.

descendants is only used in a couple of other doc files, and those instances could be changed, too.

@GGAlanSmithee
Copy link
Copy Markdown
Contributor

Isn't children and descendants two different things though? In my mind children is only the direct children (one level deep) while descendants are n levels deep - children, grandchildren etc. Not a native english speaker though, so might be mistaken.

@WestLangley
Copy link
Copy Markdown
Collaborator

@GGAlanSmithee Good point.

@aardgoose
Copy link
Copy Markdown
Contributor Author

That was my reasoning, Descendants is more accurate and Object3D already uses that term.

@mrdoob mrdoob merged commit a06fd31 into mrdoob:dev May 31, 2016
@mrdoob
Copy link
Copy Markdown
Owner

mrdoob commented May 31, 2016

Thanks!

@aardgoose aardgoose deleted the docs-fix-object-clone branch May 31, 2016 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants