Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1350 +/- ##
==========================================
- Coverage 87.82% 87.24% -0.58%
==========================================
Files 42 43 +1
Lines 2571 2588 +17
==========================================
Hits 2258 2258
- Misses 313 330 +17 ☔ View full report in Codecov by Sentry. |
|
I'm seeing some Python 3.12 + gevent issues: RuntimeError: can't create new thread at interpreter shutdown Python 3.12 no longer allows creating a thread on interpreter shutdown: |
There was a problem hiding this comment.
r+ but why are we rolling this away from uwsgi? I half remember some niggles, which is presumably where gunicorn+gevent (rather than gunicorn+meinheld) is overall more stable, yeah?
Makes me wonder if we should also move Nucleus to match - I think we should
|
Basket has been a good project to be the "lead", so to speak, on some library choices in the past. Since it's smaller and less complex. pmac and I discussed migrating basket to match bedrock so they are more in sync. In some ways, this has already been beneficial since we've just discovered an issue with gevent workers under Python 3.12 due to the above mentioned change. So it's something to solve for bedrock (and basket, assuming we agree this is a good change). |
|
Historical note: We switched to granian on bedrock so closing this for now until the dust settles. |
No description provided.