Skip to content

Playwright test and framework improvements v1#7261

Merged
emilghittasv merged 1 commit intomozilla:mainfrom
emilghittasv:playwright-docker-integration
Feb 18, 2026
Merged

Playwright test and framework improvements v1#7261
emilghittasv merged 1 commit intomozilla:mainfrom
emilghittasv:playwright-docker-integration

Conversation

@emilghittasv
Copy link
Copy Markdown
Collaborator

  • Use @cached_property for sumo_pages to achieve lazy instantiation & instance reuse.
  • Convert all UserGroupMessages methods to @staticmethod with descriptive parameter names (username, group_name)
  • Convert MyProfileMessages.get_my_profile_stage_url to @staticmethod
  • Convert KBDashboardPageMessages.get_kb_not_live_status to @staticmethod and remove unnecessary class instantiation from all test functions
  • Fix method name typo: get_list_of_all_locale_tage -> get_list_of_all_locale_tags
  • Add skip reason to bare @pytest.mark.skip decorator
  • Add missing soft-assert (with check) wrappers in test_add_new_group_leader
  • Remove incorrect soft-assert wrapper from non-assertion action step
  • Simplify date filter logic with list comprehension and named variables
  • Replace hardcoded date strings with existing variables
  • Refactor basepage, sumo_pages, top_navbar, and various page objects
  • Update test files to use refactored page utilities

@emilghittasv emilghittasv merged commit 91a3742 into mozilla:main Feb 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants