improve performance of two product support methods#7175
Merged
akatsoulas merged 1 commit intomozilla:mainfrom Jan 14, 2026
Merged
improve performance of two product support methods#7175akatsoulas merged 1 commit intomozilla:mainfrom
akatsoulas merged 1 commit intomozilla:mainfrom
Conversation
akatsoulas
approved these changes
Jan 14, 2026
| return False | ||
| else: | ||
| return config.enable_zendesk_support | ||
| return self.support_configs.filter( |
Collaborator
There was a problem hiding this comment.
nitpicking: this query and the original one perform both a single query. The performance gain is negligible here and comes from the fetching and object initialization.
Contributor
Author
There was a problem hiding this comment.
It won't perform another query for the zendesk_config object?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #7173, I noticed that we could reduce the query count of the
Product.has_ticketing_supportproperty and theProduct.questions_enabled()method.