Skip to content

chore(all): replace esbuild-register with ts-node/register #20234

Closed
dschom wants to merge 0 commit intomainfrom
worktree-switch-to-ts-node
Closed

chore(all): replace esbuild-register with ts-node/register #20234
dschom wants to merge 0 commit intomainfrom
worktree-switch-to-ts-node

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Mar 20, 2026

Because

  • Using tsc is much quicker than it used to be
  • Keeping devstack in line with deployements

This pull request

  • Swaps in tsc, ts-node/register for esbuild

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom force-pushed the worktree-switch-to-ts-node branch 2 times, most recently from aef25f5 to 1b9243e Compare March 26, 2026 20:57
@dschom dschom force-pushed the worktree-switch-to-ts-node branch 2 times, most recently from 4ea7a88 to d2f1ec8 Compare April 9, 2026 19:26
Comment thread packages/fxa-auth-server/test/support/jest-global-setup.ts Fixed
@dschom dschom force-pushed the worktree-switch-to-ts-node branch 3 times, most recently from 5ca72f5 to 7f90c07 Compare April 10, 2026 20:34
Comment thread packages/fxa-auth-server/test/scripts/bulk-mailer.in.spec.ts Fixed
Comment thread packages/fxa-auth-server/test/scripts/bulk-mailer.in.spec.ts Fixed
Comment thread packages/fxa-auth-server/test/scripts/bulk-mailer.in.spec.ts Fixed
Comment thread packages/fxa-auth-server/test/scripts/bulk-mailer.in.spec.ts Fixed
Comment thread packages/fxa-auth-server/test/support/jest-global-setup.ts Dismissed
@dschom dschom force-pushed the worktree-switch-to-ts-node branch 2 times, most recently from 67c3359 to 8a35b06 Compare April 14, 2026 01:29

await execAsync(
`node -r esbuild-register scripts/dump-users --emails ${account1Mock.email},${account2Mock.email} > ${USER_DUMP_PATH}`,
`node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/dump-users --emails ${account1Mock.email},${account2Mock.email} > ${USER_DUMP_PATH}`,
it('succeeds with valid input file and method, writing files to disk', async () => {
await execAsync(
`node -r esbuild-register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail --write ${OUTPUT_DIRECTORY}`,
`node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail --write ${OUTPUT_DIRECTORY}`,
it('succeeds with valid input file and method, writing emails to stdout', async () => {
const output = await execAsync(
`node -r esbuild-register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail`,
`node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail`,
it('succeeds with valid input file and method, sends', async () => {
await execAsync(
`node -r esbuild-register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendVerifyEmail --send`,
`node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendVerifyEmail --send`,
@dschom dschom force-pushed the worktree-switch-to-ts-node branch from 8a35b06 to 93a402a Compare April 16, 2026 02:39
@dschom dschom closed this Apr 16, 2026
@dschom dschom force-pushed the worktree-switch-to-ts-node branch from 93a402a to 9bea644 Compare April 16, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants