feat(nimbus): Advertise nimbus-devtools#15141
Open
freshstrangemusic wants to merge 1 commit intomainfrom
Open
Conversation
1c51abb to
a8cf528
Compare
Member
Author
|
Banner shown when the addon is not out of date: 
Banner shown when the addon is not detected: 
|
a8cf528 to
22b2d99
Compare
Member
Author
|
This patch is blocked until we cut the 0.4.0 release of nimbus-devtools. |
Because: - nimbus-devtools now can inform Experimenter what version is installed as of mozilla-extensions/nimbus-devtools#56; and - we want users to update their version of nimbus-devtools to the latest and greatest. this commit: - adds a banner that informs the user if a new version of nimbus-devtools is released; - adds a banner that informs the user about nimbus-devtools if they don't have it installed; and - gives users the options to suppress the banner for a day, until the next version, or permanently. Fixes #15137
22b2d99 to
028cff8
Compare
relud
approved these changes
Apr 6, 2026
| }; | ||
|
|
||
| $(() => { | ||
| void setupDevtoolsBanner(); |
Contributor
There was a problem hiding this comment.
out of curiosity how is void different from not having it here?
Member
Author
There was a problem hiding this comment.
Essentially no different. This is really a signal that we're calling an async function and not awaiting it.
Member
Author
There was a problem hiding this comment.
(if you do const x = void f() for some async function f, x will be undefined instead of a Promise`.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #15137