Skip to content

Breach Alerts component#7312

Merged
jo merged 3 commits intomozilla:mainfrom
jo:breach-alerts
Apr 21, 2026
Merged

Breach Alerts component#7312
jo merged 3 commits intomozilla:mainfrom
jo:breach-alerts

Conversation

@jo
Copy link
Copy Markdown
Contributor

@jo jo commented Apr 8, 2026 •
edited
Loading

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@jo jo force-pushed the breach-alerts branch 4 times, most recently from b5d6c2c to 011d5a6 Compare April 8, 2026 13:43
@jo jo changed the title Breach alerts Breach Alerts component Apr 8, 2026
@jo jo force-pushed the breach-alerts branch from 011d5a6 to bf87a29 Compare April 8, 2026 13:47
@Vinnl Vinnl self-requested a review April 8, 2026 14:05
@jo jo force-pushed the breach-alerts branch 2 times, most recently from fb8644c to c5deef7 Compare April 20, 2026 12:37
Vinnl
Vinnl approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the Rust code and AS conventions, but I integrated this into Firefox using your patch, and it did what it says on the tin :)

Added some inline suggestions, but none of them are blockers, and for each of them one could also make a valid argument that they should be ignored, so 🤷

Comment thread components/breach-alerts/src/api.rs Outdated
Comment thread components/breach-alerts/src/api.rs Outdated
Comment thread components/breach-alerts/src/api.rs
@jo jo force-pushed the breach-alerts branch from c5deef7 to f919588 Compare April 20, 2026 13:57
@jo jo requested a review from bendk April 20, 2026 15:48
bendk
bendk approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

My only slight concern is that we should make sure we're tracking any errors that come from this component and fixing them. At some point soon I'd love to set up a dashboard so that credential management can do that. I've been working on the dashboards for a while and I think they're close to being ready for wider use.

@jo
Copy link
Copy Markdown
Contributor Author

jo commented Apr 21, 2026

My only slight concern is that we should make sure we're tracking any errors that come from this component and fixing them. At some point soon I'd love to set up a dashboard so that credential management can do that. I've been working on the dashboards for a while and I think they're close to being ready for wider use.

Yes, this sounds good!

@jo jo added this pull request to the merge queue Apr 21, 2026
Merged via the queue into mozilla:main with commit d1707b4 Apr 21, 2026
15 checks passed
@jo jo deleted the breach-alerts branch April 21, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vinnl Vinnl Vinnl approved these changes

@bendk bendk bendk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jo @Vinnl @bendk