Fix disconnecting an account after starting to reauth it.#7310
Merged
mhammond merged 1 commit intomozilla:mainfrom Apr 9, 2026
Merged
Fix disconnecting an account after starting to reauth it.#7310mhammond merged 1 commit intomozilla:mainfrom
mhammond merged 1 commit intomozilla:mainfrom
Conversation
STR: * Have an account in a bad state needing reauth * Start to sign in to fix the problem, but close the window instead of completing. * Select "Remove Account" Observe `fxa-state-machine-error: Invalid state transition: Authenticating -> Disconnect` in logcat, the account state remains the same. There is a `FxaEvent::CancelOAuthFlow` but doesn't seem to be used in practice. Regardless, this change still seems correct.
bendk
approved these changes
Apr 8, 2026
Contributor
bendk
left a comment
There was a problem hiding this comment.
Makes sense to me and it seems fairly safe. If you don't get an answer on the local substitution build, then I'd be for landing this.
Member
Author
|
I managed to get things working to test and this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(as I noted in slack, I'm struggling to test local a-s with Fenix, but I think this looks correct. I might hold off landing it until I can actually test it though?)
STR:
Observe
fxa-state-machine-error: Invalid state transition: Authenticating -> Disconnectin logcat, the account state remains the same.There is a
FxaEvent::CancelOAuthFlowbut doesn't seem to be used in practice. Regardless, this change still seems correct.Pull Request checklist
[ci full]to the PR title.