Fix PKCS#11 struct packing on Windows to match NSS 1-byte alignment by mhammond · Pull Request #7308 · mozilla/application-services

mhammond · 2026-04-07T22:06:58Z

Breaking changes: This PR follows our breaking change policy
- This PR follows the breaking change policy:
  - This PR has no breaking API changes, or
  - There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
Quality: This PR builds and tests run cleanly
- Note:
  - For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
  - If this pull request includes a breaking change, consider cutting a new release after merging.
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
Dependencies: This PR follows our dependency management guidelines
- Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

bendk

Wow, that's wild, thanks for the fix.

Fix PKCS#11 struct packing on Windows to match NSS 1-byte alignment

4acbe61

via ahochheiden in https://phabricator.services.mozilla.com/D292613

mhammond requested a review from bendk April 10, 2026 05:51

bendk approved these changes Apr 10, 2026

View reviewed changes

mhammond added this pull request to the merge queue Apr 12, 2026

Merged via the queue into mozilla:main with commit e021196 Apr 12, 2026
14 checks passed

mhammond deleted the push-zvltszxkqlpm branch April 12, 2026 01:19

Provide feedback