Skip to content

exit with -1 on deploy error - #62

Closed
Mekajiki wants to merge 1 commit into
motdotla:masterfrom
Mekajiki:exit-255-on-deploy-error
Closed

exit with -1 on deploy error#62
Mekajiki wants to merge 1 commit into
motdotla:masterfrom
Mekajiki:exit-255-on-deploy-error

Conversation

@Mekajiki

Copy link
Copy Markdown

This enable us to detect successfulness of node-lambda deploy by exit code when invoked in a shell.

@DeviaVir

Copy link
Copy Markdown
Collaborator

Does #54 not also give you the correct exit code?

@DeviaVir

DeviaVir commented Apr 8, 2016

Copy link
Copy Markdown
Collaborator

Confirmed:

throw.js:

throw 'error!';

throw.sh:

#!/bin/bash
node ./throw.js
# will print nodes exit code, e.g. 0 for success
echo $?

throw.sh output:

error!
1

The exit code would have been 0 without the throw.

Closing this PR in favor of #54

@DeviaVir DeviaVir closed this Apr 8, 2016
@Mekajiki
Mekajiki deleted the exit-255-on-deploy-error branch October 11, 2016 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants