Skip to content

exclude .env file from being uploaded to amazon - #43

Closed
perwagner wants to merge 1 commit into
motdotla:masterfrom
perwagner:feature/exclude_env
Closed

exclude .env file from being uploaded to amazon#43
perwagner wants to merge 1 commit into
motdotla:masterfrom
perwagner:feature/exclude_env

Conversation

@perwagner

Copy link
Copy Markdown

I wanted to avoid having .env files uploaded to AWS so that my credentials wasn't exposed on the AWS platform if someone tried to download the function after having used 'node-lambda deploy'.

@rafalyesware

Copy link
Copy Markdown

I totally support this, but also felt compelled to add general exclusion support, since I not only had a .env sitting around, but several flavors of it (.env.dev, .env.prod), as well as other configuration and non-code files that don't need to be shipped up to AWS either.

See #48 for that change.

@motdotla

Copy link
Copy Markdown
Owner

Thanks for these @rafalyesware and @perwagner. I'll look at these this weekend, and either one or the other (with some default) will come into the repo.

@rafalyesware

Copy link
Copy Markdown

+1 Thanks!

On Wed, Jan 20, 2016 at 10:50 AM, Mot notifications@github.com wrote:

Thanks for these @rafalyesware https://github.com/rafalyesware and
@perwagner https://github.com/perwagner. I'll look at these this
weekend, and either one or the other (with some default) will come into the
repo.


Reply to this email directly or view it on GitHub
#43 (comment).

@DeviaVir

DeviaVir commented Apr 8, 2016

Copy link
Copy Markdown
Collaborator

I vote we close this PR in favor of the finegrained ignores made possible in #48; I'd rather not ignore all env files either way.

@DeviaVir DeviaVir closed this Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants