Partial refactor, multi region, version tag - #2
Merged
Merged
Conversation
added 9 commits
February 3, 2015 11:26
Contributor
Author
|
@motdotla why is there a test for the package.json version? Shouldn't it just test for existence? |
Owner
|
I like to test for package version, because it forces me to make sure I do bump the version. It acts as sort of a second check. |
Owner
|
👍 |
Contributor
Author
|
Last push makes sure we stick to single quotes. |
elbuo8
pushed a commit
that referenced
this pull request
Feb 3, 2015
Partial refactor, multi region, version tag
DeviaVir
pushed a commit
that referenced
this pull request
Apr 9, 2016
Merge upstream/master with kecaps:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.