Skip to content

Update libpng to 1.6.57 - #3673

Closed
mattleibow wants to merge 1 commit into
mainfrom
dev/update-libpng
Closed

mattleibow wants to merge 1 commit into
mainfrom
dev/update-libpng

Conversation

@mattleibow

Copy link
Copy Markdown
Collaborator

Update libpng from 1.6.54 to 1.6.57 to fix critical security vulnerabilities:

  • CVE-2026-25646 (CRITICAL) — Heap buffer overflow in \png_set_quantize(), 30-year-old bug
  • CVE-2026-33416 (HIGH) — Use-after-free between \png_struct\ and \png_info\
  • CVE-2026-33636 (HIGH) — ARM/AArch64 NEON palette expansion OOB read/write

Analysis: Patch-level update (1.6.54 → 1.6.57). No BUILD.gn changes needed. No breaking API changes. All 20 BUILD.gn source files verified present.

Changes:

  • \�xternals/skia\ submodule → points to \dev/update-libpng\ branch with updated DEPS
  • \cgmanifest.json\ → libpng version 1.6.54 → 1.6.57

Required skia PR: mono/skia#182

Update libpng from 1.6.54 to 1.6.57 to fix security vulnerabilities:

- CVE-2026-25646 (CRITICAL) - Heap buffer overflow in png_set_quantize()
- CVE-2026-33416 (HIGH) - Use-after-free between png_struct and png_info
- CVE-2026-33636 (HIGH) - ARM NEON palette expansion OOB read/write

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

📦 Try the packages from this PR

Warning

Do not run these scripts without first reviewing the code in this PR.

Step 1 — Download the packages

bash / macOS / Linux:

curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 3673

PowerShell / Windows:

iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 3673"

Step 2 — Add the local NuGet source

dotnet nuget add source ~/.skiasharp/hives/pr-3673/packages --name skiasharp-pr-3673
More options
Option Description
--successful-only / -SuccessfulOnly Only use successful builds
--force / -Force Overwrite previously downloaded packages
--list / -List List available artifacts without downloading
--build-id ID / -BuildId ID Download from a specific build

Or download manually from Azure Pipelines — look for the nuget artifact on the build for this PR.

Remove the source when you're done:

dotnet nuget remove source skiasharp-pr-3673

github-actions Bot pushed a commit that referenced this pull request Apr 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📖 Documentation Preview

The documentation for this PR has been deployed and is available at:

🔗 View Staging Site
🔗 View Staging Docs
🔗 View Staging Gallery

This preview will be updated automatically when you push new commits to this PR.


This comment is automatically updated by the documentation staging workflow.

@mattleibow mattleibow added the upgrading/4.x Issues and discussions relating to the upgrade from 3.x to 4.x label Apr 16, 2026
@mattleibow mattleibow added this to the 4.x Preview 1 milestone Apr 16, 2026
Copilot AI mentioned this pull request Apr 18, 2026
5 tasks
@mattleibow mattleibow closed this Apr 23, 2026
@mattleibow
mattleibow deleted the dev/update-libpng branch April 23, 2026 13:58
github-actions Bot pushed a commit that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upgrading/4.x Issues and discussions relating to the upgrade from 3.x to 4.x

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant